(no subject)
Mar. 17th, 2009 01:29 pm![[personal profile]](https://www.dreamwidth.org/img/silk/identity/user.png){kind=small}
ysobelSo, uh, I can finally say that I've contributed code to DW.
*pauses to o.O a bit*
...English-stripping is not, in my mind, coding. (It kind of is, but it's a different sort of thing.) The bug I found+filed+fixed (changing </b> to </a> on one page) wasn't really coding either. Bug 432 (update page refreshing the security if there was an error) was nominally coding, but after a lot of frustrated poking I went to #dw for help, and it was Dre that figured out what was going on, why, where, and how to fix it, so I didn't do most of the work.
Bug 158, though? That was all me. I still went to #dw for help -- particularly Afuna and Janine and Mark -- but I did it. And I'm fucking proud.
(158 changes the behaviour of image placeholders to give the user the option of what to do with images that don't have HTML-defined size. Current behaviour is to treat them as large images, so that if you have image placeholders set at all, unknown-dimension images get placeholdered. Modified behaviour is to give the user the option of whether to treat them as large or small images; if placeholders are "all" or "none" it doesn't really matter, but otherwise that option takes effect. And that involved defining and setting a new userprop (and it helped when I remembered to include a line in the code to *save* that userprop), adding a new parameter to the HTML cleaner user options, and then throwing in code such that if the HTML doesn't define size, it uses the userprop option instead. I broke [fixably, of course] my dreamhack account several times, which is pretty common for something like this, but I finally got it working.)
(and given that I haven't really done any programming in ten years, and a lot of the LJ/DW code basically gets filed under "magic" in my brain because I don't have a clue how it works? yeah. really fucking proud. \o/)
I'm not going to become a full-on coder; I don't know enough for that. And 158 wasn't an open-beta-blocking bug, so it wasn't as productive as it might have been. And I probably did it relatively clumsily, and there are ways I can see it being shinier (eg having that option hidden when placeholders are set to all or none) but don't know how.
But still.
\o/
*pauses to o.O a bit*
...English-stripping is not, in my mind, coding. (It kind of is, but it's a different sort of thing.) The bug I found+filed+fixed (changing </b> to </a> on one page) wasn't really coding either. Bug 432 (update page refreshing the security if there was an error) was nominally coding, but after a lot of frustrated poking I went to #dw for help, and it was Dre that figured out what was going on, why, where, and how to fix it, so I didn't do most of the work.
Bug 158, though? That was all me. I still went to #dw for help -- particularly Afuna and Janine and Mark -- but I did it. And I'm fucking proud.
(158 changes the behaviour of image placeholders to give the user the option of what to do with images that don't have HTML-defined size. Current behaviour is to treat them as large images, so that if you have image placeholders set at all, unknown-dimension images get placeholdered. Modified behaviour is to give the user the option of whether to treat them as large or small images; if placeholders are "all" or "none" it doesn't really matter, but otherwise that option takes effect. And that involved defining and setting a new userprop (and it helped when I remembered to include a line in the code to *save* that userprop), adding a new parameter to the HTML cleaner user options, and then throwing in code such that if the HTML doesn't define size, it uses the userprop option instead. I broke [fixably, of course] my dreamhack account several times, which is pretty common for something like this, but I finally got it working.)
(and given that I haven't really done any programming in ten years, and a lot of the LJ/DW code basically gets filed under "magic" in my brain because I don't have a clue how it works? yeah. really fucking proud. \o/)
I'm not going to become a full-on coder; I don't know enough for that. And 158 wasn't an open-beta-blocking bug, so it wasn't as productive as it might have been. And I probably did it relatively clumsily, and there are ways I can see it being shinier (eg having that option hidden when placeholders are set to all or none) but don't know how.
But still.
\o/